BridgeAR · GitHub

@BridgeAR added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Dec 19, 2019

@BridgeAR

ZYSzys

Closed

2 tasks

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 2, 2020

mcollina

gireeshpunathil

The input was not validated so far and that caused unwanted side
effects. E.g., `undefined` became the string `'undefined'`. It was
expected to fail or to end up as empty string.
Now all input is validated to be either some type of array buffer
view or a string. That way it's always clear what the user intents.
Fixes: nodejs#31025

@BridgeAR

BridgeAR added a commit that referenced this pull request

Feb 5, 2020
The input was not validated so far and that caused unwanted side
effects. E.g., `undefined` became the string `'undefined'`. It was
expected to fail or to end up as empty string.
Now all input is validated to be either some type of array buffer
view or a string. That way it's always clear what the user intents.
PR-URL: #31030
Fixes: #31025
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

BridgeAR pushed a commit that referenced this pull request

Feb 5, 2020
PR-URL: #31030
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Closed

3 tasks

ZYSzys added a commit that referenced this pull request

Feb 13, 2020
PR-URL: #31731
Refs: #31030
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>

Merged

targos added a commit to targos/citgm that referenced this pull request

May 1, 2020
- Use Node.js 14 in actions/setup-node
- Add Node.js 14.x to the test matrix
- Remove CI: true from the environment
The variable is already set by GitHub
- Fix bug in test fixture
Discovered with v14.x because of
nodejs/node#31030.

Merged

targos added a commit to nodejs/citgm that referenced this pull request

May 2, 2020
- Use Node.js 14 in actions/setup-node
- Add Node.js 14.x to the test matrix
- Remove CI: true from the environment
The variable is already set by GitHub
- Fix bug in test fixture
Discovered with v14.x because of
nodejs/node#31030.

Closed

Closed

Merged

4 tasks

chipx86 added a commit to chipx86/less-plugin-autoprefix that referenced this pull request

Jan 9, 2021
A Node.js 14.x added strict type checking when writing files to disk,
preventing methods with their own `.toString()` method from being
written to disk and generating a `ERR_INVALID_ARG_TYPE` error in the
process. This affected using this plugin in combination with
`--source-map`.
The behavioral change was introduced in
nodejs/node#31030 and recently fixed in
nodejs/node#34993. That fix was not
comprehensive, and did not resolve the issue for the plugin.
To avoid this issue for all versions of Node, we no longer assume there
will be an implicit call to `SourceMapGenerator.toString()`. Instead,
it's now explicitly called when setting the data to write for the source
map, fixing source map generation.
This was tested on the latest releases of Node 12 through 15.

Open

Closed

Merged

Read the original on github.com ↗