BridgeAR · GitHub

This aligns the `equal` and `deepEqual()` implementations with the
strict versions by accepting `NaN` as being identical in case both
sides are NaN.
Refs: nodejs#30350 (comment)

@BridgeAR

@nodejs-github-bot nodejs-github-bot added assert

Issues and PRs related to the assert subsystem.

util

Issues and PRs related to the built-in util module.

labels

Dec 2, 2019

@BridgeAR BridgeAR added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Dec 2, 2019

@BridgeAR

@BridgeAR

lundibundi

addaleax

devnexen

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 3, 2019

@BridgeAR

Trott

Trott

Trott

@BridgeAR

BridgeAR added a commit that referenced this pull request

Dec 6, 2019
This aligns the `equal` and `deepEqual()` implementations with the
strict versions by accepting `NaN` as being identical in case both
sides are NaN.
Refs: #30350 (comment)
PR-URL: #30766
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@BridgeAR

Merged

Read the original on github.com ↗