changed the title stream: don't emit errors after destroy stream: don't emit error after destroy()

ronag mentioned this pull request

Closed

ronag mentioned this pull request

Closed

4 tasks

Trott mentioned this pull request

Closed

lpinca previously requested changes Aug 20, 2019

Trott added the tsc-agenda

label

4 tasks

ronag added a commit that referenced this pull request

Previously destroy could be called multiple times causing inconsistent
and hard to predict behavior. Furthermore, since the stream _destroy
implementation can only be called once, the behavior of applying destroy
multiple times becomes unclear.
This changes so that only the first destroy() call is executed and any
subsequent calls are noops.
PR-URL: #29197
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4 tasks

lpinca added a commit to websockets/ws that referenced this pull request

Merged

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

codebytere added a commit to electron/electron that referenced this pull request

4 tasks

codebytere added a commit to electron/electron that referenced this pull request

2 tasks

Trott pushed a commit that referenced this pull request

Refs: #29197 (comment)
PR-URL: #35326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Refs: #29197 (comment)
PR-URL: #35326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

joesepi pushed a commit to joesepi/node that referenced this pull request

Closed