nodejs-github-bot · GitHub

Make `http2.createServer()` support `net.Server` options.

@nodejs-github-bot added the http2

Issues or PRs related to the http2 subsystem.

label

May 20, 2019

BridgeAR

addaleax

@trivikr trivikr added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

May 22, 2019

danbev pushed a commit that referenced this pull request

May 23, 2019
Make `http2.createServer()` support `net.Server` options.
PR-URL: #27782
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@lpinca

lpinca deleted the pass/options-to-parent-ctor branch

May 23, 2019 05:48

targos pushed a commit that referenced this pull request

May 28, 2019
Make `http2.createServer()` support `net.Server` options.
PR-URL: #27782
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Merged

Read the original on github.com ↗