nodejs-github-bot · GitHub

@nodejs-github-bot added the fs

Issues and PRs related to the fs subsystem / file system.

label

Apr 1, 2019

@BridgeAR BridgeAR added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Apr 2, 2019

bnoordhuis

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 3, 2019

mcollina

@BridgeAR BridgeAR added wip

Issues and PRs that are still a work in progress.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Apr 9, 2019

@Trott

@BridgeAR

@BridgeAR BridgeAR removed the wip

Issues and PRs that are still a work in progress.

label

Sep 26, 2019

@BridgeAR

@BridgeAR

@BridgeAR

@BridgeAR

@BridgeAR

@BridgeAR

@devnexen

Multiple `fs` functions have a `mode` and or `flag` option. In some
cases those have been mistaken and named wrongly. All of those faulty
entries have been fixed.
Besides that some indentation is also aligned with the rest of the
document.
This fixes a few bugs in `fs`. E.g., `fs.promises.access` accepted
strings as mode. It should have only accepted numbers. It will now
always validate the flags and the mode argument in an consistent way.
This consolidates some examples to concentrate the reader on the
important aspects and to reduce reading overhead.

@BridgeAR

mcollina

@BridgeAR BridgeAR added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed review wanted

PRs that need reviews.

labels

Jan 12, 2020

BridgeAR added a commit that referenced this pull request

Jan 12, 2020
Multiple `fs` functions have a `mode` and or `flag` option. In some
cases those have been mistaken and named wrongly. All of those faulty
entries have been fixed.
Besides that some indentation is also aligned with the rest of the
document.
PR-URL: #27044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

BridgeAR added a commit that referenced this pull request

Jan 12, 2020
This fixes a few bugs in `fs`. E.g., `fs.promises.access` accepted
strings as mode. It should have only accepted numbers. It will now
always validate the flags and the mode argument in an consistent way.
PR-URL: #27044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

BridgeAR added a commit that referenced this pull request

Jan 12, 2020
This consolidates some examples to concentrate the reader on the
important aspects and to reduce reading overhead.
PR-URL: #27044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Merged

Closed

3 tasks

Read the original on github.com ↗