added the test

Issues and PRs related to the tests.

label

Nov 29, 2018

addaleax added the tls

Issues and PRs related to the tls subsystem.

label

Nov 30, 2018

sam-github added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Nov 30, 2018

Closed

sam-github changed the title ~~test: test TLS client authentication~~ test/document TLS authentication, then add support for TRUSTED CERTIFICATE pem headers

Nov 30, 2018

This was referenced

Dec 5, 2018

Closed

sam-github added a commit that referenced this pull request

Dec 11, 2018

TLS client authentication should be tested, including failure scenarios.
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

sam-github added a commit that referenced this pull request

Dec 11, 2018

Support the same PEM certificate formats for the ca: option to
tls.createSecureContext() that are supported by openssl when loading a
CAfile.
Fixes: #24761
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BethGriggs pushed a commit that referenced this pull request

Dec 17, 2018

TLS client authentication should be tested, including failure scenarios.
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BethGriggs pushed a commit that referenced this pull request

Dec 17, 2018

Support the same PEM certificate formats for the ca: option to
tls.createSecureContext() that are supported by openssl when loading a
CAfile.
Fixes: #24761
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Merged

BethGriggs added a commit that referenced this pull request

Dec 18, 2018

Notable changes:
* **test**:
  * test TLS client authentication (Sam Roberts)
    [#24733](#24733)
* **tls**:
  * support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
    [#24733](#24733)
* **tools**:
  * update ESLint to 5.10.0 (cjihrig)
    [#24903](#24903)
* **util**:
  * add inspection getter option (Ruben Bridgewater)
    [#24852](#24852)
PR-URL: #25102

MylesBorins pushed a commit that referenced this pull request

Dec 18, 2018

Notable changes:
* **test**:
  * test TLS client authentication (Sam Roberts)
    [#24733](#24733)
* **tls**:
  * support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
    [#24733](#24733)
* **tools**:
  * update ESLint to 5.10.0 (cjihrig)
    [#24903](#24903)
* **util**:
  * add inspection getter option (Ruben Bridgewater)
    [#24852](#24852)
PR-URL: #25102

BethGriggs added a commit that referenced this pull request

Dec 18, 2018

Notable changes:
* **tls**:
  * support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
    [#24733](#24733)
* **util**:
  * add inspection getter option (Ruben Bridgewater)
    [#24852](#24852)
PR-URL: #25102

BethGriggs added a commit that referenced this pull request

Dec 18, 2018

Notable changes:
* **tls**:
  * support "BEGIN TRUSTED CERTIFICATE" for ca: (Sam Roberts)
    [#24733](#24733)
* **util**:
  * add inspection getter option (Ruben Bridgewater)
    [#24852](#24852)
PR-URL: #25102

Closed

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019

TLS client authentication should be tested, including failure scenarios.
PR-URL: nodejs#24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019

Support the same PEM certificate formats for the ca: option to
tls.createSecureContext() that are supported by openssl when loading a
CAfile.
Fixes: nodejs#24761
PR-URL: nodejs#24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 17, 2019

TLS client authentication should be tested, including failure scenarios.
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2019

TLS client authentication should be tested, including failure scenarios.
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

sam-github added a commit to sam-github/node that referenced this pull request

Apr 29, 2019

Support the same PEM certificate formats for the ca: option to
tls.createSecureContext() that are supported by openssl when loading a
CAfile.
Fixes: nodejs#24761
PR-URL: nodejs#24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Merged

MylesBorins pushed a commit that referenced this pull request

May 16, 2019

TLS client authentication should be tested, including failure scenarios.
PR-URL: #24733
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was referenced

May 29, 2019

Closed