added the assert

Issues and PRs related to the assert subsystem.

label

Aug 17, 2015

Ilya Shaisultanov and others added 2 commits

April 15, 2016 11:31

Addresses nodejs#2385.
Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.

Addresses nodejs#2407.
Break out conditional into named variables for readability.
Explain the purpose of `message` in throws/doesNotThrow assertions.

jasnell pushed a commit that referenced this pull request

Apr 18, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 19, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 20, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 20, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

Closed

MylesBorins pushed a commit that referenced this pull request

Apr 20, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Apr 21, 2016

Closed

MylesBorins pushed a commit that referenced this pull request

Apr 21, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

joelostrowski pushed a commit to joelostrowski/node that referenced this pull request

Apr 25, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: nodejs#2385
PR-URL: nodejs#2407
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Apr 26, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

Closed

MylesBorins pushed a commit that referenced this pull request

May 3, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 6, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 18, 2016

Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if `actual` value is an error use
`util.isError` instead of `instanceof`.
Fixes: #2385
PR-URL: #2407
Reviewed-By: James M Snell <jasnell@gmail.com>

Merged