nodejs-github-bot · GitHub

@nodejs-github-bot added the fs

Issues and PRs related to the fs subsystem / file system.

label

Oct 19, 2018

vsemozhetbyt

lpinca

Make fs.open() and fs.openSync() more economic to use by making the
flags argument optional. You can now write:
    fs.open(file, cb)
Instead of the more verbose:
    fs.open(file, 'r', cb)
This idiom is already supported by functions like fs.readFile().

@bnoordhuis

@refack refack added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Oct 23, 2018

@refack refack added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 23, 2018

Closed

2 tasks

@Trott

Trott pushed a commit to Trott/io.js that referenced this pull request

Oct 26, 2018
Make fs.open() and fs.openSync() more economic to use by making the
flags argument optional. You can now write:
    fs.open(file, cb)
Instead of the more verbose:
    fs.open(file, 'r', cb)
This idiom is already supported by functions like fs.readFile().
PR-URL: nodejs#23767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos pushed a commit that referenced this pull request

Oct 27, 2018
Make fs.open() and fs.openSync() more economic to use by making the
flags argument optional. You can now write:
    fs.open(file, cb)
Instead of the more verbose:
    fs.open(file, 'r', cb)
This idiom is already supported by functions like fs.readFile().
PR-URL: #23767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Merged

targos pushed a commit that referenced this pull request

Nov 1, 2018
Make fs.open() and fs.openSync() more economic to use by making the
flags argument optional. You can now write:
    fs.open(file, cb)
Instead of the more verbose:
    fs.open(file, 'r', cb)
This idiom is already supported by functions like fs.readFile().
PR-URL: #23767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

This was referenced

Nov 2, 2018

Closed

Closed

Closed

Closed

@rvagg rvagg mentioned this pull request

Nov 8, 2018

Closed

rvagg added a commit to rvagg/io.js that referenced this pull request

Nov 12, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request

Nov 12, 2018
Was missed on original PR.
Ref: nodejs#23767
PR-URL: nodejs#24240
Refs: nodejs#23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Nov 14, 2018
Was missed on original PR.
Ref: #23767
PR-URL: #24240
Refs: #23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request

Nov 15, 2018
Was missed on original PR.
Ref: nodejs#23767
PR-URL: nodejs#24240
Refs: nodejs#23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request

Dec 14, 2018
Was missed on original PR.
Ref: #23767
PR-URL: #24240
Refs: #23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018
Was missed on original PR.
Ref: #23767
PR-URL: #24240
Refs: #23767
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Apr 8, 2019
Make fs.open() and fs.openSync() more economic to use by making the
flags argument optional. You can now write:
    fs.open(file, cb)
Instead of the more verbose:
    fs.open(file, 'r', cb)
This idiom is already supported by functions like fs.readFile().
PR-URL: #23767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

Merged

This was referenced

May 29, 2019

Closed

Closed

Closed

Closed

Closed

Read the original on github.com ↗