nodejs-github-bot
added
the
c++
label
Feb 25, 2018Closed
4 tasks
TimothyGu
added
semver-major
labels
Feb 25, 2018Closed
TimothyGu deleted the doc-deprecate-process-env-non-string branch
March 7, 2018 18:44TimothyGu added a commit that referenced this pull request
Mar 7, 2018PR-URL: #18990 Refs: #15089 Refs: #18158 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Closed
2 tasks
TimothyGu pushed a commit that referenced this pull request
Mar 7, 2018MayaLekova pushed a commit to MayaLekova/node that referenced this pull request
May 8, 2018PR-URL: nodejs#18990 Refs: nodejs#15089 Refs: nodejs#18158 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request
May 8, 2018This is a follow-up of nodejs#18990. A new deprecation id was assigned in it, but it was not reflected in code and test. PR-URL: nodejs#19209 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Closed