added the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Jan 29, 2018

mcollina added stream

Issues and PRs related to the stream subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

and removed lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Jan 30, 2018

mcollina added fs

Issues and PRs related to the fs subsystem / file system.

http2

Issues or PRs related to the http2 subsystem.

labels

Jan 30, 2018

mafintosh changed the title ~~Improving streams error handling~~ stream: improving error handling

Jan 30, 2018

mcollina pushed a commit that referenced this pull request

Mar 6, 2018

This improves error handling for streams in a few ways.
1. It ensures that no user defined methods (_read, _write, ...) are run
after .destroy has been called.
2. It introduces an explicit error to tell the user if they are write to
write, etc to the stream after it has been destroyed.
3. It makes streams always emit close as the last thing after they have
been destroyed
4. Changes the default _destroy to not gracefully end streams.
It also updates net, http2, zlib and fs to the new error handling.
PR-URL: #18438
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

mafintosh deleted the streams-error-handling-fix branch

March 6, 2018 12:57

mcollina added a commit to mcollina/node that referenced this pull request

Mar 6, 2018

Closed

2 tasks

mcollina added a commit that referenced this pull request

Mar 6, 2018

See: #18438
PR-URL: #19169
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Closed

4 tasks

Closed

4 tasks

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018

This improves error handling for streams in a few ways.
1. It ensures that no user defined methods (_read, _write, ...) are run
after .destroy has been called.
2. It introduces an explicit error to tell the user if they are write to
write, etc to the stream after it has been destroyed.
3. It makes streams always emit close as the last thing after they have
been destroyed
4. Changes the default _destroy to not gracefully end streams.
It also updates net, http2, zlib and fs to the new error handling.
PR-URL: nodejs#18438
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018

See: nodejs#18438
PR-URL: nodejs#19169
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Merged

4 tasks

kjin mentioned this pull request

Sep 11, 2018

Closed

3 tasks

Closed

2 tasks

Closed

3 tasks

mcollina added a commit to mcollina/node that referenced this pull request

Jan 10, 2019

mcollina added a commit that referenced this pull request

Jan 12, 2019

See: #25373
See: #18438
PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

addaleax pushed a commit that referenced this pull request

Jan 14, 2019

See: #25373
See: #18438
PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Jan 16, 2019

See: nodejs#25373
See: nodejs#18438
PR-URL: nodejs#25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

Merged

BethGriggs pushed a commit that referenced this pull request

Apr 28, 2019

See: #25373
See: #18438
PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

BethGriggs pushed a commit that referenced this pull request

May 10, 2019

See: #25373
See: #18438
PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 16, 2019

See: #25373
See: #18438
PR-URL: #25413
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

Closed

4 tasks