nodejs-github-bot · GitHub

@nodejs-github-bot added the assert

Issues and PRs related to the assert subsystem.

label

Jan 23, 2018

@BridgeAR BridgeAR added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jan 23, 2018

vsemozhetbyt

starkwang

@BridgeAR

In case no arguments are passed to `assert.ok` it should just
use a default message. Otherwise `assert.ok` can not be used as
a callback.

@BridgeAR

joyeecheung

joyeecheung

@joyeecheung

@maclover7

@cjihrig

@BridgeAR

mcollina

@BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 30, 2018

joyeecheung

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Feb 1, 2018
In case no arguments are passed to `assert.ok` it should just
use a default message. Otherwise `assert.ok` can not be used as
a callback.
PR-URL: nodejs#18319
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@addaleax addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 4, 2018

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018
In case no arguments are passed to `assert.ok` it should just
use a default message. Otherwise `assert.ok` can not be used as
a callback.
PR-URL: nodejs#18319
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@BridgeAR

BridgeAR deleted the no-args-simple-assert branch

April 1, 2019 23:38

Read the original on github.com ↗