nodejs-github-bot · GitHub

@addaleax

@nodejs-github-bot added buffer

Issues and PRs related to the buffer subsystem.

c++

Issues and PRs that require attention from people who are familiar with C++.

labels

Dec 2, 2017
Zero-fill when `Buffer.alloc()` receives invalid fill data.
A solution like nodejs#17427 which switches
to throwing makes sense, but is likely a breaking change.
This suggestion leaves the behaviour of `buffer.fill()` untouched,
since any change to it would be a breaking change, and lets
`Buffer.alloc()` check whether any filling took place or not.
Refs: nodejs#17427
Refs: nodejs#17423

@addaleax

apapirovski

ofrobots

tniessen

Closed

@addaleax

addaleax added a commit that referenced this pull request

Dec 5, 2017
PR-URL: #17428
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit that referenced this pull request

Dec 5, 2017
Zero-fill when `Buffer.alloc()` receives invalid fill data.
A solution like #17427 which switches
to throwing makes sense, but is likely a breaking change.
This suggestion leaves the behaviour of `buffer.fill()` untouched,
since any change to it would be a breaking change, and lets
`Buffer.alloc()` check whether any filling took place or not.
PR-URL: #17428
Refs: #17427
Refs: #17423
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit to addaleax/node that referenced this pull request

Dec 5, 2017
PR-URL: nodejs#17428
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Merged

evanlucas added a commit that referenced this pull request

Dec 7, 2017
Notable changes:
* **buffer**:
  * buffer allocated with an invalid content will now be zero filled (Anna Henningsen) #17428
* **deps**:
  * openssl updated to 1.0.2n (Shigeki Ohtsu) #17526
PR-URL: #17531

Merged

MylesBorins added a commit that referenced this pull request

Dec 7, 2017

evanlucas added a commit that referenced this pull request

Dec 8, 2017
Notable changes:
* **buffer**:
  * buffer allocated with an invalid content will now be zero filled (Anna Henningsen) #17428
* **deps**:
  * openssl updated to 1.0.2n (Shigeki Ohtsu) #17526
PR-URL: #17531

MylesBorins added a commit that referenced this pull request

Dec 8, 2017

MylesBorins pushed a commit that referenced this pull request

Dec 8, 2017
Notable changes:
* **buffer**:
  * buffer allocated with an invalid content will now be zero filled (Anna Henningsen) #17428
* **deps**:
  * openssl updated to 1.0.2n (Shigeki Ohtsu) #17526
PR-URL: #17531

MylesBorins added a commit that referenced this pull request

Dec 8, 2017

MylesBorins pushed a commit that referenced this pull request

Dec 8, 2017
Notable changes:
* **buffer**:
  * buffer allocated with an invalid content will now be zero filled (Anna Henningsen) #17428
* **deps**:
  * openssl updated to 1.0.2n (Shigeki Ohtsu) #17526
PR-URL: #17531

Read the original on github.com ↗