added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

errors

Issues and PRs related to JavaScript errors originated in Node.js core.

labels

Nov 6, 2017

j0t3x mentioned this pull request

Nov 6, 2017

Closed

jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Nov 8, 2017

addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 30, 2017

changes in c++ are in the computeSecret function, but the thrown
exception that was moved to JS land was in BufferToPoint
function, here i let the allocation error be thrown so the only value
returned is the nullptr that i use later to catch the error in
computeSecret, to then construct the exception in JS land.
an ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error was added to errors.js
and with that, subsequent changes to docs and tests were made.
Fixes: #16625
Refs: https://www.iacr.org/archive/pkc2003/25670211/25670211.pdf

addaleax pushed a commit that referenced this pull request

Dec 1, 2017

changes in c++ are in the computeSecret function, but the thrown
exception that was moved to JS land was in BufferToPoint
function, here i let the allocation error be thrown so the only value
returned is the nullptr that i use later to catch the error in
computeSecret, to then construct the exception in JS land.
an ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error was added to errors.js
and with that, subsequent changes to docs and tests were made.
PR-URL: #16849
Refs: https://www.iacr.org/archive/pkc2003/25670211/25670211.pdf
Fixes: #16625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 7, 2017