nodejs-github-bot · GitHub

@nodejs-github-bot added domain

Issues and PRs related to the domain subsystem.

process

Issues and PRs related to the process subsystem.

labels

Oct 15, 2017

@addaleax addaleax added the wip

Issues and PRs that are still a work in progress.

label

Oct 15, 2017

addaleax

@jasnell

mcollina

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

AndreasMadsen

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018
Due to some changes to async tracking of http and also
in how domains are handled, it's no longer necessary
to manually copy domain from req to res in http code.
PR-URL: #18477
Refs: #16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018
It is no longer necessary to explicitly set the handle
to inherit the Timeout domain.
PR-URL: #18477
Refs: #16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018
Due to some changes to async tracking of http and also
in how domains are handled, it's no longer necessary
to manually copy domain from req to res in http code.
PR-URL: #18477
Refs: #16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018
It is no longer necessary to explicitly set the handle
to inherit the Timeout domain.
PR-URL: #18477
Refs: #16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018
Due to some changes to async tracking of http and also
in how domains are handled, it's no longer necessary
to manually copy domain from req to res in http code.
PR-URL: #18477
Refs: #16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Feb 21, 2018
It is no longer necessary to explicitly set the handle
to inherit the Timeout domain.
PR-URL: #18477
Refs: #16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018
Due to some changes to async tracking of http and also
in how domains are handled, it's no longer necessary
to manually copy domain from req to res in http code.
PR-URL: nodejs#18477
Refs: nodejs#16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request

May 8, 2018
It is no longer necessary to explicitly set the handle
to inherit the Timeout domain.
PR-URL: nodejs#18477
Refs: nodejs#16222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Closed

2 tasks

misterdjules pushed a commit that referenced this pull request

Oct 5, 2018

Julien Gilli

test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.
This is no longer the case, and as such that test is no longer needed.
R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Oct 6, 2018
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.
This is no longer the case, and as such that test is no longer needed.
R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Oct 7, 2018
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.
This is no longer the case, and as such that test is no longer needed.
R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

misterdjules pushed a commit to misterdjules/node-1 that referenced this pull request

Oct 9, 2018

Julien Gilli

test-microtask-queue-integration-domain.js tests that the behavior of
another test, test-microtask-queue-integration.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in nodejs#16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.

Closed

2 tasks

misterdjules pushed a commit to misterdjules/node-1 that referenced this pull request

Oct 9, 2018

Julien Gilli

test-microtask-queue-run-domain.js tests that the behavior of another
test, test-microtask-queue-run.js, is still consistent when the core
domain module is loaded.
This was needed because before the changes in nodejs#16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.

Closed

2 tasks

misterdjules pushed a commit that referenced this pull request

Oct 9, 2018

Julien Gilli

test-microtask-queue-integration-domain.js tests that the behavior of
another test, test-microtask-queue-integration.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in #16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.
PR-URL: #23342
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

misterdjules pushed a commit that referenced this pull request

Oct 9, 2018

Julien Gilli

test-microtask-queue-run-domain.js tests that the behavior of another
test, test-microtask-queue-run.js, is still consistent when the core
domain module is loaded.
This was needed because before the changes in #16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.
PR-URL: #23343
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Oct 17, 2018
test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in
#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.
This is no longer the case, and as such that test is no longer needed.
R-URL: #23252
Refs: #16222
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Oct 17, 2018
test-microtask-queue-integration-domain.js tests that the behavior of
another test, test-microtask-queue-integration.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in #16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.
PR-URL: #23342
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Oct 17, 2018
test-microtask-queue-run-domain.js tests that the behavior of another
test, test-microtask-queue-run.js, is still consistent when the core
domain module is loaded.
This was needed because before the changes in #16222 were merged, the
core domain module would replace the function that would call nextTick
callbacks with a different implementation.
This is no longer the case, and therefore that test is no longer needed.
PR-URL: #23343
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Closed

Closed

Closed

abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request

May 5, 2024

Julien Gilli

test-microtask-queue-run-immediate-domain.js tests that the behavior of
another test, test-microtask-queue-run-immediate.js, is still
consistent when the core domain module is loaded.
This was needed because before the changes in
nodejs/node#1622 were merged, the core domain
module would replace the function that would call nextTick callbacks
with a different implementation.
This is no longer the case, and as such that test is no longer needed.
Refs: nodejs/node#16222

Read the original on github.com ↗