TimothyGu · GitHub

@TimothyGu

@nodejs-github-bot nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Sep 30, 2017

@TimothyGu TimothyGu added domain

Issues and PRs related to the domain subsystem.

vm

Issues and PRs related to the vm subsystem.

labels

Sep 30, 2017

addaleax

bnoordhuis

The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
Fixes: nodejs#15673

@TimothyGu

@TimothyGu

TimothyGu added a commit to TimothyGu/node that referenced this pull request

Oct 4, 2017
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
PR-URL: nodejs#15695
Fixes: nodejs#15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Closed

2 tasks

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Oct 12, 2017
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
PR-URL: nodejs/node#15695
Fixes: nodejs/node#15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Closed

4 tasks

TimothyGu added a commit to TimothyGu/node that referenced this pull request

Oct 22, 2017
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
Backport-PR-URL: REPLACEME
PR-URL: nodejs#15695
Fixes: nodejs#15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas pushed a commit that referenced this pull request

Oct 23, 2017
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
Backport-PR-URL: #16074
PR-URL: #15695
Fixes: #15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Read the original on github.com ↗