nodejs-github-bot · GitHub

@nodejs-github-bot added the cluster

Issues and PRs related to the cluster subsystem.

label

Jul 8, 2017

Closed

4 tasks

Closed

@mutantcornholio

mcollina

cjihrig

refack

refack

@mutantcornholio

@refack

@refack

Closed

Merged

addaleax added a commit to addaleax/node that referenced this pull request

Jul 18, 2017
- Add missing `changes:` entry
- Use full sentences
- Use proper indentation
Ref: nodejs#14140
PR-URL: nodejs#14349
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Merged

addaleax pushed a commit that referenced this pull request

Jul 18, 2017
* Capitalization and punctuation.
* `setupMaster` contained info about `settings` which where incomplete.
PR-URL: #14140
Fixes: #8495
Fixes: #12941
Refs: #9659
Refs: #13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request

Jul 18, 2017
10 ports for each test-case is too much.
Not enough ports for new test cases, considering ~100 ports per file.
PR-URL: #14140
Fixes: #8495
Fixes: #12941
Refs: #9659
Refs: #13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request

Jul 18, 2017
Added an option to override inspector port for workers using
`settings.inspectPort` will override default port incrementing behavior.
Also, using this option allows to set 0 port for the whole cluster.
PR-URL: #14140
Fixes: #8495
Fixes: #12941
Refs: #9659
Refs: #13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request

Jul 18, 2017
- Add missing `changes:` entry
- Use full sentences
- Use proper indentation
Ref: #14140
PR-URL: #14349
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request

Jul 18, 2017

addaleax added a commit that referenced this pull request

Jul 18, 2017
- Add missing `changes:` entry
- Use full sentences
- Use proper indentation
Ref: #14140
PR-URL: #14349
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 added a commit to Fishrock123/node that referenced this pull request

Jul 19, 2017

Fishrock123 pushed a commit that referenced this pull request

Jul 19, 2017
* Capitalization and punctuation.
* `setupMaster` contained info about `settings` which where incomplete.
PR-URL: #14140
Fixes: #8495
Fixes: #12941
Refs: #9659
Refs: #13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 pushed a commit that referenced this pull request

Jul 19, 2017
10 ports for each test-case is too much.
Not enough ports for new test cases, considering ~100 ports per file.
PR-URL: #14140
Fixes: #8495
Fixes: #12941
Refs: #9659
Refs: #13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 pushed a commit that referenced this pull request

Jul 19, 2017
Added an option to override inspector port for workers using
`settings.inspectPort` will override default port incrementing behavior.
Also, using this option allows to set 0 port for the whole cluster.
PR-URL: #14140
Fixes: #8495
Fixes: #12941
Refs: #9659
Refs: #13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 pushed a commit that referenced this pull request

Jul 19, 2017
- Add missing `changes:` entry
- Use full sentences
- Use proper indentation
Ref: #14140
PR-URL: #14349
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 added a commit that referenced this pull request

Jul 19, 2017

Fishrock123 added a commit that referenced this pull request

Jul 19, 2017

Closed

Read the original on github.com ↗