jasnell · GitHub

@jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Feb 10, 2017

bnoordhuis

sam-github

sam-github

Commit  a116358  added a deprecation warning when pbkdf2 was called without an
explicit `digest` argument. This was because the default digest is `sha1`,
which is not-recommended from a security point of view. This upgrades it
to a runtime error when `digest` is undefined per the plan discussed in
the original issue.
Ref: nodejs@ a116358 

@jasnell

thefourtheye

Fishrock123

jasnell added a commit that referenced this pull request

Feb 13, 2017
Commit  a116358  added a deprecation warning when pbkdf2 was called without an
explicit `digest` argument. This was because the default digest is `sha1`,
which is not-recommended from a security point of view. This upgrades it
to a runtime error when `digest` is undefined per the plan discussed in
the original issue.
Ref:  a116358 
PR-URL: #11305
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Closed

3 tasks

addaleax added a commit to addaleax/express that referenced this pull request

Feb 15, 2017
Calling `crypto.pbkdf2()` without a digest has been deprecated in Node
and is scheduled to be broken in Node 8.
Fix this by actually passing a digest.
ref: nodejs/node#11305

Closed

Closed

Closed

Open

Merged

@panva panva mentioned this pull request

Sep 20, 2022

Merged

Read the original on github.com ↗