Closed

watilde changed the title ~~url: repeated '&' in a paramsString will be skipped~~ querystring, url: repeated '&' in a paramsString will be skipped

Jan 23, 2017

joyeecheung added url

Issues and PRs related to the legacy built-in url module.

whatwg-url

Issues and PRs related to the WHATWG URL implementation.

labels

Jan 24, 2017

+ update state machine in parse
  + repeated sep should be adjusted
  + `&=&=` should be `{ '': [ '', '' ] }`
+ add test cases for querystring and URLSearchParams
Fixes: nodejs#10454

jasnell pushed a commit that referenced this pull request

Feb 2, 2017

* update state machine in parse
  * repeated sep should be adjusted
  * `&=&=` should be `{ '': [ '', '' ] }`
* add test cases for querystring and URLSearchParams
Fixes: #10454
PR-URL: #10967
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

mscdex added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Feb 2, 2017

watilde deleted the feature/fixes-querystring-parse branch

February 2, 2017 21:21

watilde restored the feature/fixes-querystring-parse branch

February 2, 2017 21:23

This was referenced

Feb 6, 2017

Closed

krydos pushed a commit to krydos/node that referenced this pull request

Feb 25, 2017

* update state machine in parse
  * repeated sep should be adjusted
  * `&=&=` should be `{ '': [ '', '' ] }`
* add test cases for querystring and URLSearchParams
Fixes: nodejs#10454
PR-URL: nodejs#10967
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

Closed

watilde deleted the feature/fixes-querystring-parse branch

April 11, 2017 18:58