Merged

Conversation

Define the `mrb_bigint_p()` macro function, which returns false if `MRB_USE_BIGINT` is undefined.

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the mrb_bigint_p() macro to ensure it is consistently defined across the codebase, regardless of whether MRB_USE_BIGINT is enabled. This change streamlines conditional logic in various files by removing redundant preprocessor directives, leading to cleaner and more maintainable code.

Highlights

Consistent Macro Definition: The mrb_bigint_p() macro is now always defined in include/mruby/value.h. If MRB_USE_BIGINT is not enabled, the macro will simply return FALSE.
Simplified Conditional Logic: Conditional compilation blocks (#ifdef MRB_USE_BIGINT) surrounding calls to mrb_bigint_p() have been removed in mrbgems/mruby-numeric-ext/src/numeric_ext.c and src/range.c, simplifying the code as the macro is now guaranteed to exist.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩