Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the internal implementation of attr_reader and attr_writer in mruby. It introduces a mechanism to explicitly mark C functions that implement these accessors with their expected argument counts. This optimization allows attr_reader to avoid an unnecessary call to mrb_get_args, streamlining its execution and contributing to the ongoing effort to improve argument handling within the mruby core.

Highlights

• Optimized attr_reader: The attr_reader implementation no longer calls mrb_get_args, improving efficiency by avoiding unnecessary argument parsing for methods that do not expect arguments.
• Explicit Argument Marking: C functions implementing attr_reader and attr_writer are now explicitly marked with their expected argument counts (0 for reader, 1 for writer) using a new aargc parameter in mod_attr_define.
• MRB_PROC_NOARG Flag: A new flag, MRB_PROC_NOARG, is set on the RProc for methods that expect no arguments, allowing the runtime to optimize argument handling and avoid redundant checks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

leviongit deleted the core/attr_accessor/nullary branch