Merged
Merged
Conversation
the previous wording may have been taken as mruby not permitting the overloading of operators on any class
Summary of Changes
Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the documentation to provide more accurate information regarding mruby's limitations on operator overriding and class subclassing. The changes clarify that operator overriding restrictions apply only to primitive classes due to VM optimizations, and that String classes, like Array, cannot support instance variables when subclassed to reduce memory. This prevents potential misunderstandings about mruby's capabilities.
Highlights
- Operator Overriding Clarification: The documentation has been updated to clarify that operator overriding restrictions apply specifically to primitive classes, not all classes, addressing potential misunderstandings.
- String Subclassing Limitations: The documentation now explicitly states that
Stringclasses, similar toArray, do not support instance variables when subclassed due to memory optimization.
๐ง New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Changelog- doc/guides/language.md
- Updated the heading "Array Subclasses" to "Array and String Subclasses".
- Modified the explanation for subclassing limitations to include
StringalongsideArray. - Revised the "Operator Overriding" section to specify that operators of primitive classes cannot be overridden and used
String#+as an example.
- doc/limitations.md
- Reworded the "Operator modification" section to state that operators on some primitive classes cannot be overridden because they are optimized in the VM.
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐ and ๐ on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โฉ
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>