dearblue ยท GitHub

Summary of Changes

Hello @dearblue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances mruby's C-level error handling by introducing a robust 'ensure'-like macro. This change streamlines resource management and exception safety in C extensions and core components, making the codebase more resilient and easier to maintain by centralizing cleanup logic. It also simplifies gem dependencies where error handling was previously managed.

Highlights

  • New MRB_ENSURE() Macro: Introduced a new C macro, MRB_ENSURE(), which provides 'ensure'-like functionality for C code within mruby, guaranteeing that a cleanup block is executed even if a global jump (exception) occurs during the protected code execution.
  • Refactoring Existing Error Handling: Existing usages of mrb_protect_error() and mrb_ensure() across mruby-array-ext, mruby-bigint, and mruby-eval gems have been refactored to utilize the new MRB_ENSURE() macro, simplifying the error handling and cleanup patterns.
  • Dependency Removal: The mruby-array-ext gem's explicit dependency on mruby-error has been removed, as the core error handling mechanisms are now integrated directly into mruby.h and mruby/error.h via the new macro.
  • Unique Name Generation: Added helper macros (MRB_UNIQNAME, MRB_UNIQNAME_1, MRB_UNIQNAME_2) to include/mruby.h to generate unique variable names, which are used internally by MRB_ENSURE() to prevent naming conflicts.

๐Ÿง  New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

Read the original on github.com โ†—