Passing a large integer value as the first argument to `Array#ary_combination_init` could cause an incorrect memory allocation due to integer overflow.
This would result in an invalid write during the subsequent zero-fill of the memory.
To resolve the issue, it has been replaced with `mrb_calloc()`.
However, since the current `mrb_calloc()` returns `NULL` due to overflow, it has been modified to raise an exception as a clear error.

Summary of Changes

Hello @dearblue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical integer overflow vulnerability within the Array#ary_combination_init method, which could lead to incorrect memory allocation and potential invalid writes. The changes involve refactoring the memory allocation strategy to leverage mrb_calloc for safer, zero-initialized memory, and crucially, enhancing mrb_calloc itself to explicitly raise an exception upon detecting an allocation size overflow. This ensures more robust error handling and prevents silent failures in memory management.

Highlights

Integer Overflow Prevention: Implemented a check in ary_combination_init to prevent integer overflow when n exceeds SIZE_MAX on systems where MRB_INT_MAX is larger than SIZE_MAX, raising an E_ARGUMENT_ERROR.
Refactored Memory Allocation: Replaced the manual mrb_malloc and subsequent zero-filling loop with a single call to mrb_calloc for state->indices in ary_combination_init, improving code conciseness and safety.
Enhanced mrb_calloc Error Handling: Modified mrb_calloc to raise an E_ARGUMENT_ERROR when an allocation size calculation results in an overflow, instead of silently returning NULL. This provides clearer error reporting for memory allocation failures.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Comment on lines 244 to 259

		void *p;

		if (nelem > 0 && len > 0 &&
		nelem <= SIZE_MAX / len) {
		if (nelem == 0 \|\| len == 0) {
		p = NULL;
		}
		else if (nelem <= SIZE_MAX / len) {
		size_t size = nelem * len;
		p = mrb_malloc(mrb, size);

		memset(p, 0, size);
		}
		else {
		p = NULL;
		mrb_raise(mrb, E_ARGUMENT_ERROR, "memory allocation overflow");
		}

		return p;