Merged

Conversation

This removes the magic number that also gets repeated in the code.
Adding a constant adds extra context without having to add comments.

Summary of Changes

Hello @pusewicz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code readability and maintainability by eliminating a magic number. It extracts a specific numerical constant, which represents a golden ratio prime, into a named preprocessor macro. This change centralizes the definition of the constant and replaces its direct occurrences with the new, more descriptive name, making the code easier to understand and modify.

Highlights

Code Clarity & Maintainability: Replaced the hardcoded numerical value 0x9e3779b97f4a7c15ULL with a descriptive constant GOLDEN_RATIO_PRIME in the mrbgems/mruby-set/src/set.c file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

		KHASH_DEFINE(set_val, mrb_value, char, FALSE, kset_hash_value, kset_equal_value)

		#define KSET_INITIAL_SIZE 4
		#define GOLDEN_RATIO_PRIME 0x9e3779b97f4a7c15ULL