buty4649 ยท GitHub

@buty4649

Only use local build_config.rb when current directory != MRUBY_ROOT.

@buty4649

gemini-code-assist[bot]

Summary of Changes

Hello @buty4649, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented a fix to how mruby locates its build configuration file. The change addresses an issue where a local build_config.rb might be inadvertently used even when working directly in the project's root directory. My modification ensures that the system intelligently selects the appropriate configuration, prioritizing the default configuration when operating from the MRUBY_ROOT unless explicitly told otherwise, thereby improving the predictability of the build process.

Highlights

  • Conditional build_config.rb Loading: I've refined the logic within the mruby_config_path method in lib/mruby/build.rb. Previously, the system would always check for a local build_config.rb first. Now, a local build_config.rb will only be prioritized if the current working directory (Dir.pwd) is not the MRUBY_ROOT. This prevents unintended overrides when working directly within the mruby root directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

gemini-code-assist[bot]

Comment on lines +63 to +67

if Dir.pwd != MRUBY_ROOT && File.file?("./build_config.rb")
path = "./build_config.rb"
else
path = "#{MRUBY_ROOT}/build_config/default.rb"
end
Suggested by Gemini code assistant for better readability.

@matz

Read the original on github.com โ†—