buty4649 ยท GitHub

@buty4649

Add fallback to check for ./build_config.rb before using default.rb

@buty4649

gemini-code-assist[bot]

Summary of Changes

Hello @buty4649, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the mruby build system by introducing a more intuitive way to load project-specific build configurations. It automates the discovery of a local build_config.rb file, thereby improving developer convenience and reducing manual setup steps for mruby projects.

Highlights

  • Configuration Loading: I've modified the mruby_config_path method within lib/mruby/build.rb to introduce a new fallback mechanism for locating the build configuration file. Specifically, if the MRUBY_CONFIG or CONFIG environment variables are not set, the system will now first check for a build_config.rb file in the current directory.
  • Developer Experience Improvement: This change aims to streamline the development workflow for mruby users who frequently work with multiple projects and consolidate mruby source code. It eliminates the need to manually specify MRUBY_CONFIG=./build_config.rb when running rake, making the build process more convenient and less error-prone.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

gemini-code-assist[bot]

Comment on lines +63 to +67

if File.file?("./build_config.rb")
path = "./build_config.rb"
else
path = "#{MRUBY_ROOT}/build_config/default.rb"
end

@buty4649

@matz

@buty4649

buty4649 deleted the improve/build-config-file-detection branch

July 31, 2025 03:55

Merged

Read the original on github.com โ†—