Hello @hasse09052, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an inconsistency between CRuby's irb and mruby's mirb regarding the handling of empty input in the command history. In mruby's mirb, empty inputs were being added to the history, which is not the case in CRuby's irb. To align the behavior, this PR modifies mirb to prevent empty inputs from being added to the history. This change improves the user experience by reducing clutter in the history and making it easier to review past inputs.
Highlights
- Behavior Alignment: The primary goal is to align mruby's mirb behavior with CRuby's irb regarding the handling of empty input in the command history.
- History Management: The change prevents empty inputs from being added to the mirb history, reducing clutter and improving usability.
Changelog
- mrbgems/mruby-bin-mirb/tools/mirb/mirb.c
- Added a conditional check to prevent adding empty strings to the history.
- Specifically, the
MIRB_ADD_HISTORY(line)macro is now only called ifstrlen(line) > 0.
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
In mirb's realm, a change takes hold,
Empty entries, no longer bold.
A cleaner slate,
No waste to create,
History's story, now to unfold.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩