Merged
Merged
Conversation
Hello @leviongit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces the rand(Range) method and unifies the implementations of Random#rand and Kernel#rand. It modifies mrbgems/mruby-random/src/random.c to include range handling and updates mrbgems/mruby-random/test/random.rb to add tests for Kernel#rand.
Highlights
- Range Support: Adds support for
rand(Range)to generate random numbers within a specified range. - Implementation Unification: Unifies the implementations of
Random#randandKernel#randto use a common internal function. - Argument Handling: Improves argument handling for
randto support floats, integers, and ranges.
Changelog
Click here to see the changelog- mrbgems/mruby-random/src/random.c
- Added
#include <mruby/range.h>to support range operations. - Implemented
rand_range_intto generate random integers within a range. - Implemented
rand_range_floatto generate random floats within a range. - Implemented
random_rangeto handle range arguments forrand. - Implemented
random_rand_implto unify argument handling forRandom#randandKernel#rand. - Modified
random_m_randto userandom_rand_impl. - Modified
random_f_randto userandom_rand_impl. - Removed the
get_optfunction.
- Added
- mrbgems/mruby-random/test/random.rb
- Added tests for
Kernel#randto verify range and numeric argument handling.
- Added tests for
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A random number's call,
In a range, it stands tall,
From zero to one,
A new seed has begun,
In mruby, embracing all.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Comment on lines +177 to +180
| #define cast_to_float(v) \ | ||
| (mrb_float_p(v) ? mrb_float(v) \ | ||
| : mrb_integer_p(v) ? (mrb_float)mrb_integer(v) \ | ||
| : (mrb_raise(mrb, E_ARGUMENT_ERROR, ""), 0.0)) |
| return random_range(mrb, t, arg); | ||
| } | ||
|
|
||
| mrb_raise(mrb, E_ARGUMENT_ERROR, ""); |