Merged

Conversation

The following code should work
```ruby
module M
  def me
    p self
  end
  module_function :me
end
M.me
```

Hello @dearblue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue with the module_function keyword in Ruby. The goal is to ensure that methods defined within a module and made public using module_function are indeed accessible as public methods on the module itself. The change modifies the visibility setting in src/class.c and adds a test case in test/t/module.rb to verify the fix.

Highlights

Visibility Fix: The core change modifies src/class.c to set the method visibility to MT_PUBLIC when module_function is used. Previously, it was incorrectly set to MT_PRIVATE.
Test Case: A new test case is added to test/t/module.rb to confirm that a method made public via module_function can be called directly on the module.

Changelog

src/class.c
- Modified mrb_mod_module_function to set method visibility to MT_PUBLIC instead of MT_PRIVATE on line 2792.
test/t/module.rb
- Added a test case to verify that methods made public with module_function are callable on the module on lines 841-843.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

A module's secret,
Revealed by function's call,
Now public it sings.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩