dearblue ยท GitHub

@dearblue

Commit  f81cadf  identifies this as a local header file, but it is actually externally exposed.
This means it is included in the output of `mruby-config --cflags` and is therefore accessible to projects linking with pre-built libmruby.
To avoid conflicts with other projects, we add `mruby/` as a directory prefix.

@dearblue

@gemini-code-assist

Summary of Changes

Hello @dearblue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential issue where mrbgems' public header files could cause conflicts with other projects due to their inclusion in mruby-config --cflags. By consistently adding an mruby/ prefix to these header paths, the change standardizes their external exposure and mitigates naming collision risks, improving overall library compatibility.

Highlights

  • Standardized Public Header Paths: Public header files for mrbgems, previously identified as local, are now explicitly prefixed with mruby/ in their include paths. This ensures they are treated as external headers.
  • Conflict Prevention: The change prevents potential naming conflicts with other projects when linking against a pre-built libmruby, as these headers are exposed via mruby-config --cflags.
  • File Renames and Include Updates: Several _hal.h and task.h files within mrbgems have been renamed to include the mruby/ directory prefix, and all corresponding #include directives in .c files have been updated to reflect these new paths.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

gemini-code-assist[bot]

Comment on lines 41 to +42

Comment on lines +22 to +23

Read the original on github.com โ†—