sean-rose · GitHub

@sean-rose

Copy link Copy Markdown

Contributor

DENG-10432: Event timestamps in events stream for Glean server apps are consistently wrong

Per the Glean docs:

Each event contains the following data:

  • A timestamp, in milliseconds. The first event in any ping always has a value of 0, and subsequent event timestamps are relative to it.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly
…G-10432).

@sean-rose

@sean-rose

@badboy

badboy

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is indeed true.
Am I right that we always send every event in its own "ping", so the default-to-0 is always correct,?

akkomar

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is indeed true. Am I right that we always send every event in its own "ping", so the default-to-0 is always correct,?

Yes.

@badboy

Read the original on github.com ↗