Conversation
Copy link
Copy Markdown
Contributor
telemetry pipeline schemas don't allow metric values to be null, instead the object key has to be omitted entirely
Pull Request checklist
- Quality: This PR builds and tests run cleanly
make testruns without emitting any warningsmake lintruns without emitting any errors
- Tests: This PR includes thorough tests or an explanation of why it does not
- Changelog: This PR includes a changelog entry to
CHANGELOG.mdor an explanation of why it does not need one- Any breaking changes to language binding APIs are noted explicitly
Copy link
Copy Markdown
Contributor Author
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on the thing I'm not sure of. It would be good to have a test covering the scenario this PR is adding, but if you've tested this in Experimenter I can r+ and add a test later.
Copy link
Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests added, r?
Labels
None yet
2 participants
