dmueller · GitHub

@dmueller

…gured or discarding behavior

dmueller

{% for extra, metadata in event.extra_keys.items() %}
{{ extra|event_extra_name }} {{ metadata.type|go_metric_type }} // {{ metadata.description|clean_string }}
{% endfor %}
{% for extra, metadata in event.extra_keys.items() %}

dmueller

Comment on lines +253 to +286

func (g GleanEventsLogger) Record{{ ping|ping_type_name }}(
requestInfo RequestInfo,
params {{ ping|ping_type_name }},
) {
var metrics = metrics{
{% for metric_type, metrics in metrics_by_type.items() %}
{% if metric_type != 'event' %}
"{{ metric_type }}": {
{% for metric in metrics %}
{% if metric_type == 'datetime' %}
requestInfo RequestInfo,
params {{ ping|ping_type_name }},
) error {
metrics := metrics{
{% for metric_type, metrics in metrics_by_type.items() %}
{% if metric_type != 'event' %}
"{{ metric_type }}": {
{% for metric in metrics %}
{% if metric_type == 'datetime' %}
"{{ metric|metric_name }}": params.{{ metric|metric_argument_name }}.Format("2006-01-02T15:04:05.000Z"),
{% else %}
"{{ metric|metric_name }}": params.{{ metric|metric_argument_name }},
{% endif %}
{% endfor %}
},
{% endif %}
{% endfor %}
}

events := []gleanEvent{}
{% if metrics_by_type['event'] %}
if params.Event != nil {
{% else %}
"{{ metric|metric_name }}": params.{{ metric|metric_argument_name }},
{% endif %}
{% endfor %}
},
{% endif %}
{% endfor %}
}

events := []gleanEvent{}
{% if metrics_by_type['event'] %}
if params.Event != nil {
events = append(events, params.Event.gleanEvent())
}
{% endif %}
g.record("{{ ping }}", requestInfo, metrics, events)
{% endif %}
return g.record("{{ ping }}", requestInfo, metrics, events)
}

// Record and submit `{{ ping }}` ping omitting user request info
func (g GleanEventsLogger) Record{{ ping|ping_type_name}}WithoutUserInfo(
params {{ ping|ping_type_name}},
) {
g.Record{{ ping|ping_type_name }}(defaultRequestInfo, params)
params {{ ping|ping_type_name}},
) error {
return g.Record{{ ping|ping_type_name }}(defaultRequestInfo, params)

dmueller

"glean/glean"
"os"
"time"
/* IMPORTS */

@dmueller dmueller changed the title dmueller/golang remove panics [go server] replace panics with returned errors

Nov 20, 2024

@dmueller

dmueller marked this pull request as ready for review

November 20, 2024 22:53

@dmueller

@dmueller

{% for extra, metadata in event.extra_keys.items() %}
{{ extra|event_extra_name }} {{ metadata.type|go_metric_type }} // {{ metadata.description|clean_string }}
{% endfor %}
{% for extra, metadata in event.extra_keys.items() %}
tmpl_code = tmpl_code.replace("/* CODE */", code)
tmpl_code = tmpl_code.replace("/* CODE */", code).replace("/* IMPORTS */", imports)

print(tmpl_code)

@dmueller

akkomar

@akkomar

Read the original on github.com ↗