Copy link Copy Markdown

Contributor

Unfortunately some nodejs services still need to use CommonJS. This patch adds an -f option to generate JS in the CommonJS module format.

Pull Request checklist

Quality: This PR builds and tests run cleanly
- make test runs without emitting any warnings
- make lint runs without emitting any errors
Tests: This PR includes thorough tests or an explanation of why it does not
- I didn't see any existing tests for the javascript_server outputter that tests individual -f options...?
Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to language binding APIs are noted explicitly

Copy link Copy Markdown

Contributor Author

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenba for consistency with rest of the code here I'd make commonjs an option of javascript_server outputter. I put up a change in this PR to your fork: chenba#1

Merged