Pull Request checklist
- Quality: This PR builds and tests run cleanly
make testruns without emitting any warningsmake lintruns without emitting any errors
- Tests: This PR includes thorough tests or an explanation of why it does not
- Changelog: This PR includes a changelog entry to
CHANGELOG.mdor an explanation of why it does not need one- Any breaking changes to language binding APIs are noted explicitly
In the process of understanding how server implementations worked, I was creating my own metrics.yaml and pings.yaml configurations and noticed that the javascript_server output included "identifiers_fxa_account_id" even though that was not defined in my metrics.yaml.
Digging into the template, I realized that the other metrics that I did define were parameters on the methods for the event type metrics I had defined, but they were not passed into the record call.