Copy link Copy Markdown

Contributor

Pull Request checklist

Quality: This PR builds and tests run cleanly
- make test runs without emitting any warnings
- make lint runs without emitting any errors
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to language binding APIs are noted explicitly

Copy link Copy Markdown

Contributor Author

hey @badboy here's a draft I'm working on. I figured this one looked like it needed to be solved in the python and not a schema so I did it that way.

just as a point of interest, I tried to run make install-kotlin-linters and this appears to require an explicit install of coreutils on mac.

Copy link Copy Markdown

Member

just as a point of interest, I tried to run make install-kotlin-linters and this appears to require an explicit install of coreutils on mac.

probably because it uses sha256sum? We could change it to shasum -a 256

Copy link Copy Markdown

Member

Copy link Copy Markdown

Contributor Author

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments for one.
There are more errors after that because in our test data we seem to have a couple of metrics that trigger that linter and thus now fail. The proper way is to make them use either another metric type in the test or set the correct lifetime