Member

Pull Request checklist

• Quality: This PR builds and tests run cleanly
  • make test runs without emitting any warnings
  • make lint runs without emitting any errors
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to language binding APIs are noted explicitly

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member Author

I only see changes to the rust and swift jinja templates, does this need to be done for the other templates too?

hah, good that you ask. the other templates actually use ping_args from the utils.py and iterate over that list to generate arguments.

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.