Contributor

Pull Request checklist

• Quality: This PR builds and tests run cleanly
  • make test runs without emitting any warnings
  • make lint runs without emitting any errors
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to language binding APIs are noted explicitly

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributor Author

This isn't adding anything but the most basic parsing.
I assume because it's that easy it won't require any template changes, correct?

Exactly. This is how the generated code looks like:

import UrlMetricType from "@mozilla/glean/webext/private/metrics/url";
/**
 * ...
 *
 * Generated from `telemetry.test`.
 */
export const test = new UrlMetricType({
    category: "telemetry",
    name: "test",
    sendInPings: ["metrics"],
    lifetime: "user",
    disabled: false,
});

Member

This isn't adding anything but the most basic parsing.
I assume because it's that easy it won't require any template changes, correct?

Exactly. This is how the generated code looks like:

import UrlMetricType from "@mozilla/glean/webext/private/metrics/url";
/**
 * ...
 *
 * Generated from `telemetry.test`.
 */
export const test = new UrlMetricType({
    category: "telemetry",
    name: "test",
    sendInPings: ["metrics"],
    lifetime: "user",
    disabled: false,
});

It's like we planned for this!