philbooth · GitHub

This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Conversation

In  804907a , a new `request.propagateMetricsContext` method was added to
support propagation of metrics context data through each stage of the
account reset flow. What's here is something that should have been part
of that change: two calls to `request.stashMetricsContext` in the
`/account/reset` endpoint.
Those calls will not do anything now that the content server stopped
sending metrics context data to `/account/reset` in train 123. This
means that the flow completion events will not be emitted. By changing
those two calls to `request.propagateMetricsContext` instead, it fixes
the issue.

@philbooth

vbudhram

@philbooth

@philbooth

philbooth deleted the pb/account-reset-flow-complete-metrics branch

October 24, 2018 18:42

Closed

Read the original on github.com ↗