philbooth · GitHub

@philbooth

Copy link Copy Markdown

Contributor

Fixes #2665.

logEmailEventSent expects a bunch of header data that is set on an object that is not passed to it. This change just ensures those headers are copied to the argument.

@mozilla/fxa-devs r?

@philbooth

@philbooth

@philbooth

Copy link Copy Markdown

Contributor Author

Popping a train-123 label on this because it affects metrics that I want to use to decide on a success milestone for the email service OKR. Hopefully the end-to-end push tests will stop timing out at some point...

vbudhram

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbudhram

Copy link Copy Markdown

Contributor

Restarted test because e2e push tests failed.

@philbooth

@philbooth

Copy link Copy Markdown

Contributor Author

@philbooth

Closed

Read the original on github.com ↗