Contributor

Fixes #68.

@jbuck, I haven't tested this out yet, but it's what I have in mind to get the sync import working with the existing Dockerfile-nodejs.

The invocation in cloudops-deployment would look something like:

docker run -e AWS_REGION -e FXA_AMPLITUDE_API_KEY -e SYNC_INSERTID_HMAC_KEY -e SQS_QUEUE_URL --network=host --rm ${marketing_amplitude_send_docker_image} node bin/sync.js events

Just fyi.

Contributor Author

@jbuck I might need your help to test these changes out, sorry. Since I got a new machine, I can't SSH into the old redshift helper EC2 instance any more, and that's the only place I knew to access the raw data from.

Can you give me a hand testing them out at some point?

Member

Okay, I had a chance to try this out and got a v8 stacktrace:

$ node bin/sync.js events s3://filename-elided
node[6083]: ../src/node_contextify.cc:633:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' failed.
 1: 0x8db900 node::Abort() [node]
 2: 0x8db9d5  [node]
 3: 0x90f697 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [node]
 4: 0xb5df6b  [node]
 5: 0xb5ff02 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 6: 0x349e455be1d
Aborted

I also need to fix permission issues before I can actually download the file

Contributor Author

I had a chance to try this out and got a v8 stacktrace

That's an interesting one! I'm hoping it's something weird like a dependency/node version mismatch, but trying to reproduce it locally now.

Are you running on node 10? Which version specifically? And what happens if you run against node 8 (or vice versa if you're already running 8)?

Contributor Author

Are you running on node 10? Which version specifically? And what happens if you run against node 8 (or vice versa if you're already running 8)?

Good news! I've reproduced this now, so you can ignore these questions. Will report back when I understand what's up.

Contributor Author

Just recording our conversation from IRC here too, that problem seems to be specific to node 10, although I don't understand the cause yet.

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributor Author

Oh wow, thanks for checking this @jbuck!