Elchi3 · GitHub

Merged

Elchi3

merged 4 commits into

Feb 8, 2018

Merged

Conversation

@Elchi3

Copy link Copy Markdown

Member

I want to migrate faster. Let's add this warning to all readers of old compat tables:

compat-cta

@wbamberg can you review the wording?
@SphinxKnight can you translate the string to French?
@jwhitlock This will need a re-render of all MDN to be most effective.

@Elchi3

added the french translation for the message

@SphinxKnight

Copy link Copy Markdown

Contributor

@wbamberg

Copy link Copy Markdown

@Elchi3

Copy link Copy Markdown

Member Author

That's a lot better, thanks @wbamberg!

@SphinxKnight Sorry, we tweaked the wording. Do you want to add French again for this new string?

@jwhitlock

Copy link Copy Markdown

Contributor

I can re-render pages with {{CompatibilityTable}} after this is deployed, no problem.

wbamberg

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ on the wording :)

@SphinxKnight

Copy link Copy Markdown

Contributor

@Elchi3

@Elchi3

Elchi3 deleted the old-compat-cta branch

February 8, 2018 08:29

Read the original on github.com ↗