scoder · GitHub

@chripede

Copy link Copy Markdown

Contributor

Currently the style option will remove both style tags and attributes.
This change makes each an option, just like scripts and javascript.

Currently the style option will remove both style tags and attributes.
This change makes each an option, just like scripts and javascript.

@scoder

Copy link Copy Markdown

Member

This breaks both the API and a test. And it adds a new option without testing it. No way I can accept that.

@chripede

@chripede

Copy link Copy Markdown

Contributor Author

Was in a hurry and forgot the tests. I fixed the broken one and added a new one.

@scoder

Copy link Copy Markdown

Member

It still breaks the API, though. If you want a new option for such a special case, it shouldn't break all code out there. It should just be a new option.

@chripede

Copy link Copy Markdown

Contributor Author

So in order to not break the API, should I move the inline_style into the style and default inline_style to True?

@scoder

@scoder

Copy link Copy Markdown

Member

I think they should be separate options where the new one falls back to the old one if not provided. d3b73e5

Read the original on github.com ↗