Conversation
This PR has had no activity for 30 days. Please leave a comment or commit to indicate you're still actively working on it.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up and defening it from stalebot. Maybe this weekend we could get this deployed.
| @@ -0,0 +1,5 @@ | |||
| BIND=:9000 | |||
| DIFFICULTY=4 | |||
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this specify a difficulty? It looks like the thresholds section of losbters.botPolicies.yaml sets them for the various conditions?
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the documentation:
The difficulty of the challenge, or the number of leading zeroes that must be in successful responses.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's present on all the conditions in the policy, so why set a default that's never used? Or am I misunderstanding how they relate? Is it a safety measure you wanted in place for potential future conditions?
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Digging a bit more, this value is the default difficulty which gets used if the lobsters.botPolicies.yaml does not override it with a specific value.
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the best of my understanding, since we are explicitly setting the value, it's not going to do anything for us, but is needed to allow the application to boot.
This PR has had no activity for 30 days. Please leave a comment or commit to indicate you're still actively working on it.