Contributor
This the first part of #1523: the hidden scope. I'd like to move by small steps, so one scope per PR is good for me.
Please, let me know if this approach is not acceptable.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this refactoring. I've posted one question, and then please do delete the hidden method from StoryRepository. Nothing should depend on it, and I'd like to start winnowing it down and dealing with possible exceptions one-by-one than in one big bang.
Contributor Author
Thanks for starting this refactoring. I've posted one question, and then please do delete the
hiddenmethod fromStoryRepository. Nothing should depend on it, and I'd like to start winnowing it down and dealing with possible exceptions one-by-one than in one big bang.
Thanks for the review! I removed the method from StoryRepository. Also, I moved specs for hidden scope inside the describe "scopes" do...end.
Member
Thanks for this, it's great to have you start in on tidying this odd corner of the codebase. If you'd like to continue with the rest of StoryRepository, you've nailed the style of the codebase and tests, I'd love to have you continue.
nav-mike deleted the refactor-story-repository branch
May 29, 2025 17:23