ShaneK · GitHub

added 2 commits

July 24, 2026 10:17
…i-input items

@ShaneK

@ShaneK

brandyscarney

@ShaneK

@vercel

@vercel

…s in ion-app

@ShaneK

@vercel

@ShaneK

@ShaneK

@vercel

@Ionitron

@vercel

…ages
…rk into FW-7585-FW-7586

@vercel

brandyscarney

…m screenshots

@vercel

…rk into FW-7585-FW-7586

@vercel

…demo grid clipping

@vercel

…-7586

@vercel

thetaPC

@vercel

… color
# Conflicts:
#	core/src/components/checkbox/test/basic/checkbox.e2e.ts-snapshots/checkbox-focus-ios-ltr-Mobile-Chrome-linux.png
#	core/src/components/checkbox/test/basic/checkbox.e2e.ts-snapshots/checkbox-in-item-focus-ios-ltr-Mobile-Chrome-linux.png
#	core/src/components/toggle/test/basic/toggle.e2e.ts-snapshots/toggle-focus-ios-ltr-Mobile-Chrome-linux.png
#	core/src/components/toggle/test/basic/toggle.e2e.ts-snapshots/toggle-in-item-focus-ios-ltr-Mobile-Chrome-linux.png

@vercel

@Ionitron

@vercel

…rk into FW-7585-FW-7586

@vercel

brandyscarney

thetaPC

@ShaneK

@vercel

@ShaneK

@ShaneK

ShaneK deleted the FW-7585-FW-7586 branch

July 31, 2026 22:09

ShaneK added a commit that referenced this pull request

Aug 5, 2026
…ents
The keyboard focus indicator is drawn 7px outside the control, so it
widened the hit area and swallowed clicks aimed just past the control.
A checkbox clicked below itself kept focus instead of blurring, so the
next click emitted no ionFocus.
This only surfaced on next: main starts the focus-visible utility in
ion-app, so a setContent test without one never got ion-focused and
never drew the ring. next initializes it globally (#31165), so the ring
main added in #31295 now renders in those tests too.
The indicator is decorative and must never take pointer events. The ios
toggle uses box-shadow, which cannot capture them, so it needs no change.

wheakerd pushed a commit to wheakerd/ionic-framework that referenced this pull request

Aug 7, 2026
The conflicting snapshots changed on main only from the playwright 1.62.1
bump, while next changed them from real component rendering work. Carry
next's baselines forward; the checkbox focus snapshots stay on main's
because ionic-team#31295 is the code landing here.

Read the original on github.com ↗