Zac-Smucker-Bryan · GitHub

added 2 commits

June 17, 2026 09:14

@Zac-Smucker-Bryan

@Zac-Smucker-Bryan

@vercel

@Zac-Smucker-Bryan

@vercel

thetaPC

…enButton
This reverts commit  1d4c704 .
Will retest changes without the fix and new test location

@vercel

@Zac-Smucker-Bryan

@Zac-Smucker-Bryan

@Zac-Smucker-Bryan

Imports AsyncValidatorFn in form.component.ts for new function
Adds test to form.spec.ts to simulate disabled state

@Zac-Smucker-Bryan

@vercel

Removing extra space in code comment on 2 lines
Test gets disabled state and tests if they match for both initial state and after set-values is called to simulate filling out the form.

@Zac-Smucker-Bryan Zac-Smucker-Bryan changed the title fix(ion-button): sync disabled state in ion-button renderHiddenButton fix(button): sync disabled state in renderHiddenButton

Jun 23, 2026
Fixing typo in code comment for button.tsx
npm run lint

thetaPC

@Zac-Smucker-Bryan Zac-Smucker-Bryan changed the title fix(button): sync disabled state in renderHiddenButton fix(button): sync disabled state and type in renderHiddenButton

Jun 24, 2026
Removes test for syncing disabled state of visible and hidden button that unreliably passed. Adds test for syncing type of visible and hidden button.

@Zac-Smucker-Bryan

@thetaPC

Move test of async visible and hidden button type from angular to core.

@ShaneK

ShaneK

Update packages/angular/test/base/e2e/src/lazy/form.spec.ts to remoe whitespace and indentation
Co-authored-by: Shane <shane@shanessite.net>

@Zac-Smucker-Bryan

@ShaneK

@ShaneK

Merged via the queue into ionic-team:main with commit 0c76135

Jun 26, 2026

49 of 50 checks passed

Read the original on github.com ↗