ShaneK
changed the title
fix(angular): forward generic type parameter on ModalOptions and PopoverOptions
fix(angular): forward generic type parameter on ModalOptions and PopoverOptions
ShaneK deleted the fix/angular-options branch
March 19, 2026 17:20os-davidlourenco pushed a commit that referenced this pull request
Mar 26, 2026…verOptions (#31022) Issue number: resolves #31012 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? `ModalOptions` and `PopoverOptions` in `@ionic/angular` are non-generic type aliases. Using `ModalOptions<typeof MyComponent>` causes a typescript error, even though the core `@ionic/core` types accept a generic parameter. ## What is the new behavior? `ModalOptions` and `PopoverOptions` now forward the generic type parameter from their core counterparts, allowing usage like` ModalOptions<typeof MyComponent>`. The default parameter preserves backward compatibility and existing code using ModalOptions without a generic should continue to work. ## Does this introduce a breaking change? - [ ] Yes - [X] No ## Other information This was the initial and intended behavior, but got broken in #30899 unintentionally. This PR fixes the issue and creates a test to ensure it doesn't happen again. Current dev build: ``` 8.8.2-dev.11773931429.15b2a51c ```