github-actions · GitHub

amandaesmith3

…ound on dark mode

amandaesmith3 and others added 5 commits

March 25, 2024 13:09

@averyrousseau averyrousseau changed the title fix(button): activated button in toolbar no longer blends into background on dark mode fix(button): activated outline button in toolbar no longer blends into background on dark mode

Mar 25, 2024

@averyrousseau

@averyrousseau

thetaPC

amandaesmith3 added 3 commits

March 27, 2024 10:09

amandaesmith3

amandaesmith3

amandaesmith3

Merged

2 tasks

amandaesmith3 and others added 6 commits

March 27, 2024 10:17

amandaesmith3

…ound on dark mode

amandaesmith3

amandaesmith3

amandaesmith3

… into FW-5721

@averyrousseau

@averyrousseau

@averyrousseau

@averyrousseau

amandaesmith3

amandaesmith3

amandaesmith3

github-merge-queue Bot pushed a commit that referenced this pull request

Apr 1, 2024
Issue number: N/A
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
The toolbar `basic` test only checks light theme. Dark theme coverage is
required to test against the bug fixed in
#29216.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
Dark theme coverage added. This required converting the test to
`page.setContent` instead of `page.goto`, so I went ahead and split the
captured toolbars into multiple tests, including some cleanup of the
test content. Since this included changes across many different tests,
even ones not strictly related to the bug, this work has been split into
a separate PR.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
---------
Co-authored-by: ionitron <hi@ionicframework.com>

Base automatically changed from toolbar-test-split to main

April 1, 2024 18:28

amandaesmith3 and others added 2 commits

April 1, 2024 13:52

@averyrousseau averyrousseau changed the title fix(button): activated outline button in toolbar no longer blends into background on dark mode fix(button): activated outline button in toolbar no longer blends into background on MD dark mode

Apr 1, 2024

amandaesmith3

amandaesmith3 and others added 2 commits

April 1, 2024 14:02

@averyrousseau

@averyrousseau

thetaPC

@averyrousseau

@averyrousseau

Read the original on github.com ↗