github-actions · GitHub

amandaesmith3

…readers

amandaesmith3 added 14 commits

February 7, 2024 13:21

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

… tests"
This reverts commit  41594cc .

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

amandaesmith3

averyrousseau

@averyrousseau

@averyrousseau

@averyrousseau

@averyrousseau

amandaesmith3 added 3 commits

February 8, 2024 12:11

amandaesmith3

amandaesmith3

amandaesmith3

@averyrousseau

sean-perkins

@averyrousseau averyrousseau changed the title fix(overlays): ensure that only topmost overlay is visible to screen readers fix(overlays): ensure that only topmost overlay is announced by screen readers

Feb 9, 2024

@averyrousseau

@averyrousseau

Closed

Merged

2 tasks

github-merge-queue Bot pushed a commit that referenced this pull request

Mar 12, 2024
Issue number: resolves #29139
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
When implementing
#28997 we did not
consider the case where a Toast could be presented. When presenting a
Toast after presenting a Modal the linked change causes the Modal to be
hidden from screen readers.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- If the top-most overlay is a Toast then the closest non-Toast overlay
is also not hidden from screen readers.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Dev build: `7.7.5-dev.11710260658.1fc29a6c`
---------
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>

Read the original on github.com ↗